[pve-devel] [PATCH common 2/2] log actual error when remote migration ip fails

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Nov 10 12:07:21 CET 2016


On 11/09/2016 12:53 PM, Dietmar Maurer wrote:
> And output to STDERR trigger a 'die' - what for ?

Ok this is not really needed, with my proposed patch:
http://pve.proxmox.com/pipermail/pve-devel/2016-November/023933.html

the output is clear enough, sorry for the noise.


>> diff --git a/src/PVE/AbstractMigrate.pm b/src/PVE/AbstractMigrate.pm
>> index 140b479..8dd1d04 100644
>> --- a/src/PVE/AbstractMigrate.pm
>> +++ b/src/PVE/AbstractMigrate.pm
>> @@ -98,6 +98,11 @@ sub get_remote_migration_ip {
>>   	if ($line =~ m/^ip: '($PVE::Tools::IPRE)'$/) {
>>   	   $ip = $1;
>>   	}
>> +    },
>> +    errfunc => sub {
>> +	my $line = shift;
>> +	$self->log('err', $line);
>> +	die "$line\n";
>>       });
>>   
>>       return $ip;
>> -- 
>> 2.1.4
>>
>>
>> _______________________________________________
>> pve-devel mailing list
>> pve-devel at pve.proxmox.com
>> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel





More information about the pve-devel mailing list