[pve-devel] [PATCH cluster 1/4] add migration format to datacenter config

Fabian Grünbichler f.gruenbichler at proxmox.com
Fri Oct 28 12:20:24 CEST 2016


> > wouldn't it make more sense to not allow both options (and error out or
> > at least warn)?
> 
> Error-ing out on each datacenter config read seems not that ideal to me.
> As I can directly map the old setting to the new (i.e. a name change of the
> property only) doing this seems not that bad for me.
> 
> How about adding similar check to the write parser so that it gets rewritten
> to the new format if the old is set?
> 

the problem is, what if the user specifies two conflicting values? I
think at least in that case a warn or error is appropriate.

rewriting existing (non-conflicting) config files to the new schema
makes sense though.




More information about the pve-devel mailing list