[pve-devel] [PATCH manager v2 02/11] disk/controllerselector: adapt flex

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Aug 29 12:08:25 CEST 2017


The bus tye selector gets now 2/3 of the space and the bus number
spinner gets 1/3.

It looked a bit strange with both of them getting half of the space,
as on a lot of GUIs the spinner get less space (its just a number
(max 13) vs a wider text).

Signed-off-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
---

changes v1 -> v2:
 * new in this series

 www/manager6/form/ControllerSelector.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/www/manager6/form/ControllerSelector.js b/www/manager6/form/ControllerSelector.js
index fd4c66eb..002134ef 100644
--- a/www/manager6/form/ControllerSelector.js
+++ b/www/manager6/form/ControllerSelector.js
@@ -99,7 +99,6 @@ Ext.define('PVE.form.ControllerSelector', {
 	    fieldLabel: gettext('Bus/Device'),
 	    layout: 'hbox',
 	    defaults: {
-                flex: 1,
                 hideLabel: true
 	    },
 	    items: [
@@ -110,6 +109,7 @@ Ext.define('PVE.form.ControllerSelector', {
 		    noVirtIO: me.noVirtIO,
 		    noScsi: me.noScsi,
 		    allowBlank: false,
+		    flex: 2,
 		    listeners: {
 			change: function(t, value) {
 			    if (!me.rendered || !value) {
@@ -127,6 +127,7 @@ Ext.define('PVE.form.ControllerSelector', {
 		    minValue: 0,
 		    maxValue: PVE.form.ControllerSelector.maxIds.ide,
 		    value: '0',
+		    flex: 1,
 		    validator: function(value) {
 			/*jslint confusion: true */
 			if (!me.rendered) {
-- 
2.11.0





More information about the pve-devel mailing list