[pve-devel] [PATCH manager] Show VLAN aware setting in NetworkView.

Dietmar Maurer dietmar at proxmox.com
Wed Dec 6 10:00:20 CET 2017


comments inline

> On December 6, 2017 at 9:31 AM Wolfgang Link <w.link at proxmox.com> wrote:
> 
> 
> ---
>  www/manager6/node/NetworkView.js | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/www/manager6/node/NetworkView.js
> b/www/manager6/node/NetworkView.js
> index 848aa7b5..b2fe6106 100644
> --- a/www/manager6/node/NetworkView.js
> +++ b/www/manager6/node/NetworkView.js
> @@ -262,6 +262,16 @@ Ext.define('PVE.node.NetworkView', {
>  			    undefinedText: 'No'
>  			},
>  			{
> +			    xtype: 'booleancolumn',
> +			    header: gettext('VLAN aware'),
> +			    width: 80,
> +			    sortable: true,
> +			    dataIndex: 'bridge_vlan_aware',
> +			    trueText: 'Yes',
> +			    falseText: 'No',
> +			    undefinedText: 'No'

no gettext() translation for Yes/No? I suggest to use the same style we
use elsewhere ...

> +			},
> +			{
>  			    header: gettext('Ports/Slaves'),
>  			    dataIndex: 'type',
>  			    renderer: render_ports
> -- 
> 2.11.0
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel




More information about the pve-devel mailing list