[pve-devel] Ack: Re: [PATCH storage 1/3] rbd: use 'rbd ls' without '-l' to find free names

Fabian Grünbichler f.gruenbichler at proxmox.com
Thu Feb 16 09:43:50 CET 2017


On Mon, Feb 13, 2017 at 10:42:08AM -0200, Thiago Damas wrote:
> Em seg, 13 de fev de 2017 às 05:19, Fabian Grünbichler <
> f.gruenbichler at proxmox.com> escreveu:
> 
> > On Fri, Feb 10, 2017 at 01:41:42AM +0000, Thiago Damas wrote:
> > >  Can you look at this?
> > >
> > > https://bugzilla.proxmox.com/show_bug.cgi?id=1159
> >
> > seems like your report somehow slipped through the cracks - sorry.
> >
> > your "hack" seems like a very similar approach - but since we only need
> > the "short ls" for finding free disk names, we can skip some of the
> > stuff and just look at the names which interest us directly in
> > find_free_disk_name.
> 
> 
> >
> I think that the "long ls" is necessary when viewing the storage content in
> web gui.

yes, that's why I left rbd_ls as-is, and only changed the
find_free_disk_name sub ;)




More information about the pve-devel mailing list