[pve-devel] [qemu-container] Add unused mountpoints.

Wolfgang Link w.link at proxmox.com
Tue Jun 13 08:47:20 CEST 2017


On 06/13/2017 08:44 AM, Dietmar Maurer wrote:
>> On 06/12/2017 04:01 PM, Dietmar Maurer wrote:
>>>> +    # add 'unusedX' volumes to volhash
>>>> +    foreach my $key (keys %$conf) {
>>>> +	my $value = $conf->{$key};
>>>> +	if ($key =~ m/^unused/) {
>>>> +	    my $drive = PVE::QemuServer::parse_drive($key, $value);
>>>
>>> AFAIR $value is already a volid, so what is the purpose of this parse_drive
>>> call?
>>>
>>
>> In this String there is normally the size included.
>> So it is better to parse the string before we use it.
>
> Ah, I see. I am still unsure if we should really replicate unused disks...
>
What if we sync if replica attribute is presents in the unused string?




More information about the pve-devel mailing list