[pve-devel] [PATCH qemu-server 1/2] move checks to top

[Dietmar Maurer]

> On 06/13/2017 05:11 PM, Dietmar Maurer wrote:
> > I think this change is wrong!
> >
> 
> any details as to why?

At least it changes the behavior of that method.
 
> we do not modify neither $attr nor $cleanup, so the data is the same in 
> both locations.
> 
> the only thing that could be different is if parse_volume_id or path 
> dies, or if $vtype is not 'images'

exactly (behaviour change).
 
> but if we mark a volume with 'replicate=0' this all should be irrelevant 
> anyway? else we fail with an error, instead of ignoring the marked disk...

Maybe. We really need regression tests for that.
 
> as for the cdrom, this fails already when you have one set to 'none' or 
> 'cdrom' so if this patch is wrong,
> there is still an error here

I would accept a patch for that ;-)