[pve-devel] applied: [PATCH manager] pveceph: createosd: allow to create bluestore OSDs

[Fabian Grünbichler]

On Tue, Jun 27, 2017 at 06:13:23PM +0200, Dietmar Maurer wrote:
> > diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm
> > index 4402eb80..7656d5f1 100644
> > --- a/PVE/API2/Ceph.pm
> > +++ b/PVE/API2/Ceph.pm
> > @@ -180,12 +180,18 @@ __PACKAGE__->register_method ({
> >  		type => 'string',
> >  	    },
> >  	    fstype => {
> > -		description => "File system type.",
> > +		description => "File system type (filestore only).",
> >  		type => 'string',
> >  		enum => ['xfs', 'ext4', 'btrfs'],
> >  		default => 'xfs',
> >  		optional => 1,
> >  	    },
> > +	    bluestore => {
> > +		description => "Use bluestore instead of filestore.",
> > +		type => 'boolean',
> > +		default => 0,
> > +		optional => 1,
> > +	    },
> 
> isn't this just a new fstype?

no - there is FileStore with different filesystems (IIRC, historically
all of xfs, ext4, zfs, btrfs were at some point supported), and there is
BlueStore.

see e.g. the ceph-disk source:
https://github.com/ceph/ceph/blob/master/src/ceph-disk/ceph_disk/main.py#L1943

IMHO it's okay to follow upstream's API here..