[pve-devel] applied: [PATCH manager] correctly set 'nowritecache' on zfsplugin

Dietmar Maurer dietmar at proxmox.com
Wed Mar 8 06:56:14 CET 2017


Applied a modified version with cleanups, see comments inline

> On February 22, 2017 at 2:42 PM Dominik Csapak <d.csapak at proxmox.com> wrote:
> 
> 
> the logic was reversed, checking writecache enabled 'nowritecache',
> now the logic is correct, setting 'nowritecache' if 'writecache' is
> unchecked
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
> changes from v1:
>  reverse also the logic when using in an editwindow

I use 'writecache' as name for the input field, and do not touch
the input field logic (I compute the value for 'nowritecache' on 
load() and before submit inside onGetValues).

>  have to use strings because we get a string from the api

This is fixed in latest pve-manager version, so the hack is no longer 
required. But I wonder if that hack was required, why wasn't it 
required for the 'enable' field?




More information about the pve-devel mailing list