[pve-devel] applied: [PATCH manager] fix start on boot

Wolfgang Bumiller w.bumiller at proxmox.com
Fri Mar 24 10:05:15 CET 2017


applied, but...

could we stick to our bug referencing conventions, please? The commit
this one is fixing didn't do it right, and the message here could have
used the commit hash to reference the broken commit.

On Fri, Mar 24, 2017 at 08:58:20AM +0100, Fabian Grünbichler wrote:
> fix the fix for #1024
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler at proxmox.com>
> ---
> @Thomas: this seems to fix the immediate issues as reported on the forum,
> but could you please check the rest of this refactoring as well?
> 
>  PVE/API2/Nodes.pm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm
> index 03f97bf..a45ca6d 100644
> --- a/PVE/API2/Nodes.pm
> +++ b/PVE/API2/Nodes.pm
> @@ -1281,7 +1281,7 @@ my $get_start_stop_list = sub {
>  	$startup->{order} = LONG_MAX if !defined($startup->{order});
>  
>  	$resList->{$startup->{order}}->{$vmid} = $startup;
> -	$resList->{$startup->{order}}->{$vmid}->{type} = $conf->{type};
> +	$resList->{$startup->{order}}->{$vmid}->{type} = $vmlist->{$vmid}->{type};
>      }
>  
>      return $resList;
> @@ -1294,7 +1294,7 @@ my $remove_locks_on_startup = sub {
>  
>      foreach my $vmid (keys %$vmlist) {
>  	my $conf = $vmlist->{$vmid}->{conf};
> -	my $class = $conf->{class};
> +	my $class = $vmlist->{$vmid}->{class};
>  
>  	eval {
>  	    if ($class->has_lock($conf, 'backup')) {
> -- 
> 2.1.4




More information about the pve-devel mailing list