[pve-devel] [PATCH qemu-server v4 3/3] Add new qm option 'diskimport' to import external disk images

Emmanuel Kasper e.kasper at proxmox.com
Tue May 16 11:22:57 CEST 2017


>> +		completion => \&PVE::Storage::complete_storage_enabled,
>> +		optional => 0,
>> +	    },
>> +	    format => {
>> +		type => 'string',
>> +		description => 'Target format',
>> +		enum => [ 'raw', 'qcow2', 'vmdk' ],
> 
> I wonder why we allow vmdk here, but not when allocating an empty disk
> (where we explictly don't have it in the enum for the optional format
> parameter, but when guessing from the name we allow it!??)
> 
> the same applies for the clone_vm and move_disk API paths as well ;)

good point
current status is that we allow creation of vmdk disk images via
clone_vm, move_disk and in the gui, although this format has less feature

we could either
A) remove VMDK from the GUI as is not a recommended choice for new disks
( less options => quicker choice => better usability)
B) remove VMDK from GUI and remove it also from the API, including this
importdisk command

I would go for A)
any opinions ?




More information about the pve-devel mailing list