[pve-devel] [PATCH ha-manager 2/6] node status: abort update if not quorate

Dietmar Maurer dietmar at proxmox.com
Wed Nov 8 06:28:23 CET 2017


> diff --git a/src/PVE/HA/NodeStatus.pm b/src/PVE/HA/NodeStatus.pm
> index 7e6e317..4ae28dd 100644
> --- a/src/PVE/HA/NodeStatus.pm
> +++ b/src/PVE/HA/NodeStatus.pm
> @@ -117,7 +117,9 @@ my $set_node_state = sub {
>  };
>  
>  sub update {
> -    my ($self, $node_info) = @_;
> +    my ($self, $node_info, $quorate) = @_;
> +
> +    return if !$quorate;


I think we should not call this method when we are not quorate. So
adding a quorate parameter makes no sense to me. Instead, avoid the
call when not quorate?




More information about the pve-devel mailing list