[pve-devel] [PATCH qemu-server] check if ga runs before a fsfreeze-freeze/thaw

[Thomas Lamprecht]

On 11/10/2017 10:25 AM, Dominik Csapak wrote:
>>
>> Would be nice to get a warning in the (task) log if QGA is configured
>> but it's not running, IMO. So the user sees that he forgot to setup
>> QGA entirely or it seems that it does not runs anymore in the VM.
>> Looks good, besides that.
>>
> 
> i know it is not clear from the patch,
> but qga_check_running does this already
>

Ah okay, thanks for the info! then:

Reviewed-by: Thomas Lamprecht <t.lamprecht at proxmox.com>

 
> sub qga_check_running {
>     my ($vmid) = @_;
>     eval { vm_mon_cmd($vmid, "guest-ping", timeout => 3); };
>     if ($@) {
>         warn "Qemu Guest Agent are not running - $@";

s/are/is/

>         return 0;
>     }
>     return 1;
> }
>