[pve-devel] applied: [PATCH common 2/2] lock_file_full: add missing trailing newline

Wolfgang Bumiller w.bumiller at proxmox.com
Fri Nov 10 11:31:11 CET 2017


applied

On Fri, Nov 10, 2017 at 10:24:25AM +0100, Thomas Lamprecht wrote:
> When we do not instantly get the lock we print a respective message
> to stderr. This shows also up in the task logs, and if it's the last
> message before a 'Task OK' the UI gets confused an shows the task as
> erroneous.
> 
> Keep the message as its a good feedback for the user to see why an op
> seems to do nothing, so simply add a trailing newline.
> 
> Signed-off-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
> ---
>  src/PVE/Tools.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm
> index 2525e55..13e70f1 100644
> --- a/src/PVE/Tools.pm
> +++ b/src/PVE/Tools.pm
> @@ -150,7 +150,7 @@ sub lock_file_full {
>  	    or die "can't open file - $!\n";
>  
>  	if (!flock($fh, $mode|LOCK_NB)) {
> -	    print STDERR "trying to acquire lock...";
> +	    print STDERR "trying to acquire lock...\n";
>  	    my $success;
>  	    while(1) {
>  		$success = flock($fh, $mode);
> -- 
> 2.11.0




More information about the pve-devel mailing list