[pve-devel] [PATCH common v2 2/3] daemon: refactor and cleanup

Dietmar Maurer dietmar at proxmox.com
Fri Nov 10 12:38:18 CET 2017


This is a semantic change - you removed the regex - why?

> @@ -289,11 +285,7 @@ sub setup {
>  
>      if ($restart && $self->{max_workers}) {
>  	if (my $wpids = $ENV{PVE_DAEMON_WORKER_PIDS}) {
> -	    foreach my $pid (split(':', $wpids)) {
> -		if ($pid =~ m/^(\d+)$/) {
> -		    $self->{old_workers}->{$1} = 1;
> -		}
> -	    }
> +	    $self->{old_workers}->{$_} = 1 foreach (split(':', $wpids));




More information about the pve-devel mailing list