[pve-devel] [PATCH manager/storage v4 00/19] pveceph storage.cfg management

Fabian Grünbichler f.gruenbichler at proxmox.com
Tue Sep 5 14:59:29 CEST 2017


this patch series implements storage.cfg management for pveceph-managed ceph
clusters.

the following is implemented:

- allow rbd storages without a hard-coded monitor list, using
  /etc/pve/ceph.conf instead for pveceph-managed clusters and their storages
- optionally adding/removing storages when creating/destroying a pool + GUI
- creating/destroying pools happens in a worker now
- adding/removing a pveceph-managed RBD storage handles its keyring as well

the following is still missing:
- adapt RBD add/edit dialogue in GUI (follow up by Dominik)

high-level changes since v3 based on Dominik's feedback and further discussion:
- drop explicit pveceph flag in favor of simply making monhost optional

high-level changes since v2 based on Thomas' feedback:
- moved keyring handling to pve-storage (PVE::API2::Storage::Config)
- dropped add/list/removestorages API paths in PVE::API2::Ceph

high-level changes since v1:
- pveceph flag is now doing its magic on the storage plugin side as well, no
  more need to update the monhost string when adding/removing a monitor (thanks
  for the suggestion Dietmar!)
- createpool/destroypool are now using a worker
- treat more failures as fatal in API paths
- {name} API placeholder for pool names is now {pool}
- includes and extends Dominik's GUI patches to support the new functionality

changed in v4:
1, 3-5, 9

dropped in v4:
2

rest is just rebased..

pve-manager:

Dominik Csapak (3):
  add a params object to the safedestroy window
  add add storages checkbox to ceph pool creation
  add remove_storages parameter to the pool destruction

Fabian Grünbichler (12):
  ceph: add add_storage helper
  ceph: add get_storages helper
  ceph: create/destroypool: shorten variable name
  ceph/createpool: optionally add storages
  ceph/destroypool: optionally remove storages
  ceph/destroypool: refactor to use get_storages
  ceph: make create/destroypool API paths async
  ceph/destroypool: move image check into worker
  add task description for cephcreatepool
  add showProgress to SafeDestroy
  enable showProgress for create/destroy pool
  rename 'Remove' ceph pool button to 'Destroy'

 PVE/API2/Ceph.pm                   | 215 ++++++++++++++++++++++++++-----------
 www/manager6/Utils.js              |   1 +
 www/manager6/ceph/Pool.js          |  17 ++-
 www/manager6/window/SafeDestroy.js |  39 ++++++-
 4 files changed, 205 insertions(+), 67 deletions(-)


base-commit: 27769b1f5dd2ddd3efc16fb112b6fa221ea186f8

pve-storage:

Fabian Grünbichler (4):
  rbd: make monhost option optional
  rbd: refactor cmdline helpers
  rbd: implement handling of unset monhost
  rbd: manage keyring for pveceph storages

 PVE/API2/Storage/Config.pm | 24 ++++++++++++--
 PVE/Storage/RBDPlugin.pm   | 80 ++++++++++++++++++++++++----------------------
 2 files changed, 63 insertions(+), 41 deletions(-)


base-commit: 5a2eba91dcaec0ba68052579d5e0e4ebcb499ff5
-- 
2.11.0





More information about the pve-devel mailing list