[pve-devel] applied: [PATCH manager] remove obsolete Posix use clause

Wolfgang Bumiller w.bumiller at proxmox.com
Mon Sep 25 15:21:52 CEST 2017


applied

On Mon, Sep 25, 2017 at 02:39:43PM +0200, Thomas Lamprecht wrote:
> besides the cleanup purpose this fixes an actual problem, perls POSIX
> module has the following caveat:
> 
> `Everything is exported by default (with a handful of exceptions).
> This is an unfortunate backwards compatibility feature and its use is
> strongly discouraged. You should either prevent the exporting (by
> saying "use POSIX ();", as usual) and then use fully qualified names
> (e.g.  "POSIX::SEEK_END"), or give an explicit import list. If you do
> neither and opt for the default (as in "use POSIX;"), you will import
> hundreds and hundreds of symbols into your namespace.'
> 
> see `perldoc POSIX`
> 
> Signed-off-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
> ---
>  PVE/VZDump.pm | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm
> index a7e08fc8..b7779de8 100644
> --- a/PVE/VZDump.pm
> +++ b/PVE/VZDump.pm
> @@ -7,7 +7,6 @@ use PVE::Exception qw(raise_param_exc);
>  use IO::File;
>  use IO::Select;
>  use IPC::Open3;
> -use POSIX;
>  use File::Path;
>  use PVE::RPCEnvironment;
>  use PVE::Storage;
> -- 
> 2.11.0




More information about the pve-devel mailing list