[pve-devel] [PATCH manager v3 0/8] Display the SCSI controller type when adding a new drive

Emmanuel Kasper e.kasper at proxmox.com
Tue Sep 26 14:17:11 CEST 2017


Since we switched to the SCSI controller in the Wizard as the recommended controller
for hard disks (using VirtIO scsi in the backend) it was not clear for users
that they were actually using a paravirtualized driver.

An example of user confusion:
https://forum.proxmox.com/threads/proxmox-hypervisor-scsi-or-virtio.36506/#post-179056
This iproblem in the trainings as well.

Patches 1-4 are code cleanups, no change since v2.
Patches 5-8 contain the new functionality.

changes since v2:

* use a readonly display field to display the controller type instead of adding the SCSI
controller type in the BusSelection combobox. This reduces the amount of user visible changes
(the field is only displayed for SCSI buses selections) and also less intrusive as we
don't need to change the rendered values of an existing combo box.
Also this allows to store the selected SCSI controller type inside the wizard in a real
component, so we can get rid of the setHiddenWizard() method which was a bit ugly.
* write VirtIO as VirtIO Block when display a VirtIO Block controller

Emmanuel Kasper (8):
  Do not use 'autoselect' as a boolean when preselecting a bus
  Remove unused noScsi parameter
  Save the components we found via down() in a variable for later reuse.
  Use the noVirtIO ControllerSelector property to build the list of
    controllers
  Add a field to show which SCSI controller type we are currently using
  When inside the wizard, actualize the scsiType display field based on
    iothread selection
  After OS type selection in Wizard, set the appropriate SCSI controller
    type in the Hard Disk panel
  Render full name of VirtIO Block controller

 www/manager6/form/BusTypeSelector.js    |  8 ++---
 www/manager6/form/ControllerSelector.js | 59 +++++++++++++++------------------
 www/manager6/qemu/CreateWizard.js       |  5 ---
 www/manager6/qemu/HDEdit.js             | 45 +++++++++++++++++++------
 www/manager6/qemu/OSDefaults.js         |  2 +-
 www/manager6/qemu/OSTypeEdit.js         | 10 +-----
 6 files changed, 66 insertions(+), 63 deletions(-)

-- 
2.11.0





More information about the pve-devel mailing list