[pve-devel] applied: [PATCH qemu-server] importovf: explicitly returns undef

Wolfgang Bumiller w.bumiller at proxmox.com
Wed Sep 27 14:56:11 CEST 2017


applied

On Wed, Sep 27, 2017 at 02:43:11PM +0200, Emmanuel Kasper wrote:
> We set the returns value to  { type => 'null' } but we returned an empty
> string, which was confusing the cli handler.
> ---
>  PVE/CLI/qm.pm | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm
> index 0e17cc9..90a44ef 100755
> --- a/PVE/CLI/qm.pm
> +++ b/PVE/CLI/qm.pm
> @@ -599,7 +599,9 @@ __PACKAGE__->register_method ({
>  	};
>  
>  	my $wait_for_lock = 1;
> -	return PVE::QemuConfig->lock_config_full($vmid, $wait_for_lock, $importfn);
> +	PVE::QemuConfig->lock_config_full($vmid, $wait_for_lock, $importfn);
> +
> +	return undef;
>  
>      }
>  });
> -- 
> 2.11.0




More information about the pve-devel mailing list