[pve-devel] [PATCH manager 0/6] ui/qemu: Refactor and merge CPUOptions into ProcessorEdit

[Dominik Csapak]

looks mostly good to me, one thing in 5/6 which i will answer there

On 09/26/2017 01:56 PM, Thomas Lamprecht wrote:
> First rewrite the ProcessorInputPanel to declarative style
> Then do some refactoring/cleanups in CPUOptions, prepare ProcessorEdit
> for the merge and execute said merge.
> Saves us some lines of code and a separate UI element.
> 
> First patch is quite straight forward and could be applied even if the
> rest has (higher level) problems.
> 
> Thomas Lamprecht (6):
>    ui: refactor ProcessorInputPanel to declarative style
>    ui CPUOptions: cpulimits is not dependend of VM cores
>    ui CPUOptions: fix cpu.shares (cpuunits) range and name
>    ui ProcessorEdit: remove total core count displayfield
>    ui: merge CPUOptions into ProcessorEdit
>    ui ProcessorEdit: remove redundancy, 'NUMA' is a checkbox
> 
>   www/manager6/Makefile              |   1 -
>   www/manager6/qemu/CPUOptions.js    |  76 -----------------
>   www/manager6/qemu/CreateWizard.js  |   1 +
>   www/manager6/qemu/HardwareView.js  |  22 -----
>   www/manager6/qemu/ProcessorEdit.js | 162 ++++++++++++++++++++++---------------
>   5 files changed, 97 insertions(+), 165 deletions(-)
>   delete mode 100644 www/manager6/qemu/CPUOptions.js
>