[pve-devel] [Patch V2 guest-common] fix #1694: Replication risks permanently losing sync in high loads due to timeout bug

[Wolfgang Link]

> ;))
> 
> > +    };
> >  
> > -    die $err if $err;
> > +    # old snapshots will removed by next run from prepare_local_job.
> > +    warn $@ if $@;
> > +    $logfunc->("delete stale replication snapshot error: $@") if $@;
> 
> again, is this double warn + log needed? (I ask because 2 out of 3 'warn'
> statements in Replication.pm are introduced by this patch..)
> 
> (cleanup_local_snapshots already warns, which maybe should be converted
> to $logfunc as well?)

the logfunc will write the message in the replication log located /var/log/pve/replicate/<job-id>
and the warn is for the syslog/journal.

I don't know maybe it is enough to show this kind of error in the replication log?

> >  
> >      return $volumes;
> >  }
> > -- 
> > 2.11.0
> > 
> > 
> > _______________________________________________
> > pve-devel mailing list
> > pve-devel at pve.proxmox.com
> > https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel