[pve-devel] [PATCH manager v2 1/2] ui/Parser: add generic functions property_strings

[Stoiko Ivanov]

On Thu, 2 Aug 2018 15:28:31 +0200
Thomas Lamprecht <t.lamprecht at proxmox.com> wrote:

> Am 08/02/2018 um 02:51 PM schrieb Dominik Csapak:
> > On 08/02/2018 12:04 PM, Thomas Lamprecht wrote:  
> >> Am 08/01/2018 um 08:29 PM schrieb Stoiko Ivanov:  
> >>> +        } else {
> >>> +        keystring = key + '=';
> >>> +        }
> >>> +        stringparts.push(keystring+value);
> >>> +    });
> >>> +
> >>> +    return stringparts.join(',');  
> >>
> >> AFAIK, defaultKey must be a start of serialized propertyString?
> >> So you may want to ensure that this holds...  
> > 
> > no, parse_property_string in jsonschema does not care about the
> > order although when writing to the config, it does write the
> > defaultkey first 
> 
> true, still would like to have it first, and if it's only for the
> reason that I can identify it fast in in a network request from the
> browser debugger, e.g. in a fake request with params:
> 
> foo=bar,size=123451511,1,bar=42.1
> 
> the 1 isn't too obvious, isn't it?

This I agree with - I'll prepare a follow-up.
FWIW - the API/Backend should accept the property-string irrespective
of order (but write them ordered to the config file) IMO.



> 
> >>  
> >>> +    },
> >>> +
> >>>       parseQemuNetwork: function(key, value) {
> >>>       if (!(key && value)) {
> >>>           return;
> >>>  
> 
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel