[pve-devel] applied: [PATCH manager v2] fix #1884: qemu vm: pending deletion of cdrom/dvd drive shows as hard disk in hardware tab

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Aug 24 11:30:41 CEST 2018


On 8/24/18 11:05 AM, David Limbeck wrote:
> Signed-off-by: David Limbeck <d.limbeck at proxmox.com>
> ---
> changes since v1:
>     cleanup
>     code simplification
> 
> www/manager6/qemu/HardwareView.js | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js
> index a87a9df1..a1bccc3c 100644
> --- a/www/manager6/qemu/HardwareView.js
> +++ b/www/manager6/qemu/HardwareView.js
> @@ -14,7 +14,10 @@ Ext.define('PVE.qemu.HardwareView', {
>  	if (rowdef.tdCls) {
>  	    metaData.tdCls = rowdef.tdCls;
>  	    if (rowdef.tdCls == 'pve-itype-icon-storage') { 
> -		var value = me.getObjectValue(key, '', true);
> +		var value = me.getObjectValue(key, '', false);
> +		if (value === '') {
> +		    value = me.getObjectValue(key, '', true);
> +		}
>  		if (value.match(/vm-.*-cloudinit/)) {
>  		    metaData.tdCls = 'pve-itype-icon-cloud';
>  		    return rowdef.cloudheader;
> 

applied with slightly fixed-up commit message, thanks!




More information about the pve-devel mailing list