[pve-devel] [PATCH common 1/3] INotify.pm: add binmode utf8 to read/update_file

Dietmar Maurer dietmar at proxmox.com
Mon Aug 27 18:24:39 CEST 2018


> I'm not *completely* opposed to patches that enforce utf-8 on *certain*
> files. Particularly ones of which the non-comment content needs to be
> ASCII compatible anyway.
> 
> Here's the issue with utf-8:
> If the file contains non-ascii characters, our code currently reads it

Again, why do you think /etc/hosts may contain UTF8 character at all? AFAIK
those files are used to be ascii only. If you want to store UTF8 there, you need
to
encode that somehow. I would be glad to discuss that *next* week.




More information about the pve-devel mailing list