[pve-devel] [PATCH qemu-server 1/7] improve PVE/API2/Makefile

[Thomas Lamprecht]

On 2/13/18 4:47 PM, Dominik Csapak wrote:
> remove unnecessary SOURCES variable and add the directory
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
>  PVE/API2/Makefile | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/PVE/API2/Makefile b/PVE/API2/Makefile
> index 3fd85e2..b438448 100644
> --- a/PVE/API2/Makefile
> +++ b/PVE/API2/Makefile
> @@ -1,6 +1,4 @@
> -SOURCES=           \
> -	Qemu.pm 
> -

Rather use ${SOURCES} below, instead of hard coding Qemu.pm there less visibly,
mirroring the Makefile one directory level above (PVE/Makefile)?

>  .PHONY: install
>  install:
> +	install -d -m 0755 ${DESTDIR}${PERLDIR}/PVE/API2
>  	install -D -m 0644 Qemu.pm ${DESTDIR}${PERLDIR}/PVE/API2/Qemu.pm
>