[pve-devel] [PATCH manager 00/19] moving to widget-toolkit

[Thomas Lamprecht]

On 12/21/17 1:36 PM, Dominik Csapak wrote:
> this series is my part of the move to the widget-toolkit
> (excluding Utils.js; this needs more time in january)
> 
> it includes an additional feature in the api (filtering
> the syslog by service), which was nicer than changing
> the gui component to not use the feature
> 
> this is thought to be used together with thomas series
> and my 2 series for the proxmox-widget-toolkit
> 
> also included is an updated patch for including the widget toolkit
> (with version parameter)
> 
> Dominik Csapak (19):
>   add proxmox-widget-toolkit to pve gui
>   use ComboGrid from proxmox-widget-toolkit
>   use TextField from proxmox-widget-toolkit
>   use IntegerField from widget toolkit
>   use TimeView and TimeEdit from widget toolkit
>   use NetworkView/NetworkEdit from widget toolkit
>   use NodeAPT grid from widget toolkit
>   remove unused MigrateAll window
>   add rrd models
>   use RRDChart and RRDStore from widget toolkit
>   use JsonObject from widget toolkit
>   use UpdateStore from widget toolkit
>   change pve-invalid-row class to proxmox-invalid-row
>   use Tasks from widget toolkit
>   use ServiceView from widget toolkit
>   add 'service' parameter to syslog api call
>   use DNSView/DNSEdit from widget toolkit
>   create some models
>   use Proxmox.button.StdRemoveButton where possible
> 

Looks mostly OK, made a few notes to respective patches.

Additionally, the "use IntegerField from widget toolkit" needs to
get rebased as of a context change (b4603dbf8618206c72477575116d80b59a744051
fix #1605)

For combining our both series we must decide how we cope with merge
conflicts.

We could make all file deletion and Makefile changes at the end,
that would avoid most of them. But this would need us to touch most
commits again now, an separate some changes which would belong together.

Else, I may craft a tree resolving the conflicts semi-manually on top of
a v2 (with the now missing Utils switch) of yours with the conflicts
resolved and resend it all together.