[pve-devel] [PATCH manager v2 21/22] use Proxmox.Utils instead of PVE.Utils

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Jan 16 11:10:15 CET 2018


On 1/15/18 3:18 PM, Dominik Csapak wrote:
> some function are now in Proxmox.Utils instead, so we have to use that
> 

Maybe also a small comment about how Proxmox.Utils and PVE.Utils a complete
separate components, that no inheritance, or there like, is going on between
them would be nice here in the commit message.

> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---

BTW, on applying I get:

.git/rebase-apply/patch:1301: trailing whitespace.
                        Proxmox.Utils.assemble_field_data(values, { 'delete': 'node' });
.git/rebase-apply/patch:1492: trailing whitespace.
                    renderer: Proxmox.Utils.format_expire,
.git/rebase-apply/patch:2624: trailing whitespace.
                        return Proxmox.Utils.format_size(balloon*1024*1024) + "/" +
warning: 3 lines add whitespace errors.

Besides that it looks good:

Reviewed-by: Thomas Lamprecht <t.lamprecht at proxmox.com>




More information about the pve-devel mailing list