[pve-devel] [PATCH qemu-server v2 1/2] rescan update_disksize: be more verbose

[Dietmar Maurer]

comments inline

> On July 6, 2018 at 11:43 AM Thomas Lamprecht <t.lamprecht at proxmox.com> wrote:
> 
> 
> Else an user has no idea what, or if something happened.
> 
> Gets printed to tty when using qm rescan or to tasklog for the case
> where we do a rescan after restoring a backup.
> 
> Signed-off-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
> ---
> 
> changes v1 -> v2:
> * simply use prefix variable instead of print wrapper
> 
>  PVE/QemuServer.pm | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index 5829e4c..8e5d54d 100644
> --- a/PVE/QemuServer.pm
> +++ b/PVE/QemuServer.pm
> @@ -5538,6 +5538,7 @@ sub update_disksize {
>      my ($vmid, $conf, $volid_hash) = @_;
>  
>      my $changes;
> +    my $prefix = "VM $vmid:";
>  
>      # used and unused disks
>      my $referenced = {};
> @@ -5569,6 +5570,7 @@ sub update_disksize {
>  	    if ($new ne $conf->{$opt}) {
>  		$changes = 1;
>  		$conf->{$opt} = $new;
> +		print "$prefix update disk '$opt' information.\n";
>  	    }
>  	}
>      }
> @@ -5579,6 +5581,7 @@ sub update_disksize {
>  	my $volid = $conf->{$opt};
>  	my $path = $volid_hash->{$volid}->{path} if $volid_hash->{$volid};
>  	if ($referenced->{$volid} || ($path && $referencedpath->{$path})) {
> +	    print "$prefix remove entry '$opt', its volume '$volid' is in use.\n";
>  	    $changes = 1;
>  	    delete $conf->{$opt};
>  	}
> @@ -5594,7 +5597,8 @@ sub update_disksize {
>  	next if !$path; # just to be sure
>  	next if $referencedpath->{$path};
>  	$changes = 1;
> -	PVE::QemuConfig->add_unused_volume($conf, $volid);
> +	my $key = PVE::QemuConfig->add_unused_volume($conf, $volid);
> +	print "$prefix add unreferenced volume '$volid' as '$key' to config.\n";
>  	$referencedpath->{$path} = 1; # avoid to add more than once (aliases)
>      }
>  
> @@ -5617,6 +5621,8 @@ sub rescan {
>      my $updatefn =  sub {
>  	my ($vmid) = @_;
>  
> +	print "rescan volumes of VM $vmid...\n";
> +

too late

>  	my $conf = PVE::QemuConfig->load_config($vmid);
>  
>  	PVE::QemuConfig->check_lock($conf);
> -- 
> 2.18.0
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel