[pve-devel] [PATCH novnc 1/3] upgrade novnc to current master

[Thomas Lamprecht]

Am 07/23/2018 um 09:54 AM schrieb Dominik Csapak:
> On 07/20/2018 09:12 AM, Thomas Lamprecht wrote:
>> Am 07/19/2018 um 04:38 PM schrieb Dominik Csapak:
>>> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
>>> ---
>>>   novnc | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/novnc b/novnc
>>> index e91a095..f9b6d76 160000
>>> --- a/novnc
>>> +++ b/novnc
>>> @@ -1 +1 @@
>>> -Subproject commit e91a095ad6751fdb9a7bd642ad9bc75afbdaac87
>>> +Subproject commit f9b6d7665d01f31a6c0c675ec3f604e99f6b2341
>>>
>>
>> Not opposed to updating to current master, but is there any indication
>> that upstream tags v1.1 (or whatever the next tagged stable version
>> would be) soon? Or is it post 1.0, with a stable API, less problematic
>> to do (more frequent) mid-release rolling updates?
>>
> 
> sadly none of this is true
> 
> reading the upstream issues/pullrequest/discussions i get the impression
> that they neither want to update a v1 branch, nor have they made any
> comments that would suggest they try to release a v2 or something 
> similar soon
> 
> the only api they hold stable is for the 'public facig' modules
> (rfb etc) but not for the rest (so the ui page is not really handled as
> an api) so we have to face some changes there in the future
> 

Ah OK, thanks for looking into it!

> nonetheless i want to upgrade master, since there were some fixes
> for e.g. firefox alt-gr and ie numpad handling which i find rather
> important
> 

As said, I'm not opposed to updating it like this, we've done it in the
past too - especially with valid reasons like those nice bug fixes you
mentioned.

> ps. i forgot to send a patch for manager to always include the 'resize' 
> parameter, else the behaviour is kinda weird (i will send it today)
> 

OK, I'll wait for that one to test it a bit + apply, if everything looks
good here.

thanks!