[pve-devel] [PATCH qemu 1/3] debian/rules: added placeholder for adding additional targets

[Thomas Lamprecht]

On 2/19/18 8:53 PM, Geert Stappers wrote:> Without this "placeholder" is it unclear how to add additional targets.
> No real change, just preparing for change.
> 
We plan to have different packages for architectures other than x86_64,
either one with all the other we want or for each architecture a single
package.

The "Architecture: any" property in debian/control is not right, as we
explicitly provide qemu-system-x86.

So we'd rather go forward by a rework of the packaging system, i.e. use
*.install files to determine which files to put in what package and stop
removing files from the debian/rules file, so won't apply 1/3 and 3/3
for now, as they'd put multiple different arch types in a single arch
package and seem more like a workaround... We also plan to build the
package for arm64 (aarch64) from the same (this) source, so having that
in mind when reworking the packaging system would be nice. :)

> Signed-off-by: Geert Stappers <stappers at stappers.it>
> ---
>  debian/rules |   16 +++++++++++++++-
>  1 file changed, 15 insertions(+), 1 deletion(-)
> 
> diff --git a/debian/rules b/debian/rules
> index 9396228..0836f32 100755
> --- a/debian/rules
> +++ b/debian/rules
> @@ -17,6 +17,20 @@ DEB_BUILD_GNU_TYPE  ?= $(shell dpkg-architecture -qDEB_BUILD_GNU_TYPE)
>  
>  ARCH ?= $(shell dpkg-architecture -qDEB_HOST_GNU_CPU)
>  
> +TRGTS  =
> +# empty target-list defaults to building all targets
> +TRGTS +=--target-list=\"
> +TRGTS +=$(ARCH)-softmmu
> +# for build host
> +# next placeholder for additional targets
> +#TRGTS +=arm-softmmu
> +#TRGTS +=aarch64-softmmu
> +#TRGTS +=mips-softmmu
> +#TRGTS +=mipsel-softmmu
> +TRGTS +=\"
> +TRGTLST =$(shell echo $(TRGTS))
> +# to get rid of the backslashes
> +
>  PACKAGE=pve-qemu-kvm
>  destdir := $(CURDIR)/debian/$(PACKAGE)
>  
> @@ -37,7 +51,7 @@ config.status: configure
>  	# Add here commands to configure the package.
>  
>  	# guest-agent is only required for guest systems
> -	./configure --with-confsuffix="/kvm" --target-list=$(ARCH)-softmmu \
> +	./configure --with-confsuffix="/kvm" $(TRGTLST) \
>  	--prefix=/usr --datadir=/usr/share \
>  	--docdir=/usr/share/doc/pve-qemu-kvm \
>  	--sysconfdir=/etc --localstatedir=/var --disable-xen --enable-gnutls \
>