[pve-devel] [PATCH zsync] add undocumented feature in help.

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Mar 9 09:35:28 CET 2018


On 3/9/18 9:07 AM, Wolfgang Link wrote:
> ---
>  pve-zsync | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/pve-zsync b/pve-zsync
> index b3241ff..943366e 100644
> --- a/pve-zsync
> +++ b/pve-zsync
> @@ -1314,6 +1314,10 @@ pve-zsync sync -dest <string> -source <string> [OPTIONS]
>  
>  		the source can be an <VMID> or [IP:]<ZFSPool>[/Path]
>  
> +	-verbose   boolean
> +
> +		print out the sync progress.
> +
>  =head1 DESCRIPTION
>  
>  This Tool helps you to sync your VM or directory which stored on ZFS between 2 servers.
> 

It misses still in:

# pve-zsync help sync

Can you send a v2 were you add it also to the help strings?

It would be nice to use HEREDOC syntax there, as that part quite hard
to read at the moment. Transforming it in a second patch would
be much welcomed :)
Would maybe also make sense to not duplicate the text and reuse it for
the pod backed man pages... could be done by adding a hidden command
which outputs the POD, as the help variables cannot be directly expanded
in POD.

thanks,




More information about the pve-devel mailing list