[pve-devel] [PATCH storage 08/11] Register CIFSPlugin in the storage plugin system.

Wolfgang Bumiller w.bumiller at proxmox.com
Wed Mar 14 14:41:12 CET 2018


On Tue, Mar 13, 2018 at 03:11:08PM +0100, Wolfgang Link wrote:
> diff --git a/PVE/Storage/Plugin.pm b/PVE/Storage/Plugin.pm
> index 6f72cee..64d4e2f 100644
> --- a/PVE/Storage/Plugin.pm
> +++ b/PVE/Storage/Plugin.pm
> @@ -332,7 +332,7 @@ sub parse_config {
>  	    $d->{content} = $def->{content}->[1] if !$d->{content};
>  	}
>  
> -	if ($type eq 'iscsi' || $type eq 'nfs' || $type eq 'rbd' || $type eq 'sheepdog' || $type eq 'iscsidirect' || $type eq 'glusterfs' || $type eq 'zfs' || $type eq 'drbd') {
> +	if ($type eq 'iscsi' || $type eq 'nfs' || $type eq 'cifs' || $type eq 'rbd' || $type eq 'sheepdog' || $type eq 'iscsidirect' || $type eq 'glusterfs' || $type eq 'zfs' || $type eq 'drbd') {

Can we please either split this so we have 1 storage per line?
	if ($type eq 'iscsi' ||
	    $type eq 'nfs' ||
	    $type eq 'cifs' ||
        (...)

Or have a global array/hash somewhere we grep/query at this point
instead?




More information about the pve-devel mailing list