[pve-devel] [PATCH pve-manager] Add "SSD" property to IDE, SATA, and SCSI hard drives

Nick Chevsky nchevsky at gmail.com
Thu Nov 8 19:17:48 CET 2018


On Thu, Nov 8, 2018 at 4:10 AM Thomas Lamprecht <t.lamprecht at proxmox.com>
wrote:

> I'd but it in the advanced options, a lot of people running Linux VMs or
> Windows with the virtio* drivers won't care much about this, I'd guess.
>
> But move the Discard Option out to the "normal" options, where now your
> SSD is proposed, so that they switch place - with this the advanced
> options count stays the same and the discard option could really makes
> sense to be generally available.
>

Works for me!

So scratch my boxLabel idea... Also maybe call your option 'Show as SSD'
> (or something alike, if you have a better idea)? But I'm not totally
> opposed to SSD, it is correct I just want to minimize possible confusion
> - which. though, should be addressed by documentation, so you're call :-)
>

I've now renamed it "SSD emulation." If you prefer something else, feel
free to just change it in the commit to avoid further back-and-forths. :)
Once merged, I'll follow up with a pve-docs patch.

Thanks for all the feedback!

Nick



More information about the pve-devel mailing list