[pve-devel] applied: [PATCH common/qemu-server/manager/storage] cleanup and refactor mania

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Nov 19 15:31:00 CET 2018


On 11/16/18 4:17 PM, Dominik Csapak wrote:
> this series refactors and moves code involving scanning and sysfs operations
> 
> it moves all sysfs related code from storage/qemu-server into
> commons new package SysFSTools and moves the Scan api endpoints
> to pve-managers new Scan package and to its own pvesm.pm for the cli
> definitions of thos calls
> 
> this series is needed for my upcoming series regarding mediated devices
> and pci passthrough gui
> 
> this supersedes my previous series 'scan cleanup/gui pci passthrough' [1]
> 
> dependency/breaks notes:
> 
> manager depends on common patches
> qemu-server depends on common patches
> 
> storage does not depend on the others, but breaks manager without its patches
> common does not depend on the others and does not break anything(tm)
> 
> 1: https://pve.proxmox.com/pipermail/pve-devel/2018-November/034525.html

applied series with some minor fixups, thanks!

> pve-common:
> 
> Dominik Csapak (5):
>   copy pci related subs from PVE::QemuServer
>   SysFSTools.pm: refactor pci regex
>   SysFSTools.pm: implement filter in lspci
>   SysFSTools.pm: implement iommu check
>   copy scan_usb from PVE::Storage to PVE::SysFSTools
> 
>  src/Makefile          |   1 +
>  src/PVE/SysFSTools.pm | 212 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 213 insertions(+)
>  create mode 100644 src/PVE/SysFSTools.pm
> 
> qemu-server:
> 
> Dominik Csapak (1):
>   remove PCI helpers from QemuServer.pm
> 
>  PVE/QemuServer.pm     | 158 +++-----------------------------------------------
>  PVE/QemuServer/PCI.pm |   2 +
>  2 files changed, 10 insertions(+), 150 deletions(-)
> 
> pve-manager:
> 
> Dominik Csapak (5):
>   copy Scan.pm from pve-storage
>   Scan.pm: whitespace fixes
>   Scan.pm: remove unused HTTP::Status module
>   use scan_usb from PVE::SysFSTools rather than PVE::Storage
>   rename PVE::API2::Storage::Scan to PVE::API2:Scan
> 
>  PVE/API2/Makefile |   1 +
>  PVE/API2/Nodes.pm |   4 +-
>  PVE/API2/Scan.pm  | 425 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 428 insertions(+), 2 deletions(-)
>  create mode 100644 PVE/API2/Scan.pm
> 
> pve-storage:
> 
> Dominik Csapak (3):
>   move Scan API calls from PVE/API2/Storage/Scan.pm to pvesm.pm
>   remove PVE/API2/Storage/Scan.pm
>   remove usb scan code
> 
>  PVE/API2/Storage/Makefile |   2 +-
>  PVE/API2/Storage/Scan.pm  | 425 ----------------------------------------------
>  PVE/CLI/pvesm.pm          | 343 ++++++++++++++++++++++++++++++++++++-
>  PVE/Storage.pm            |  56 ------
>  4 files changed, 336 insertions(+), 490 deletions(-)
>  delete mode 100644 PVE/API2/Storage/Scan.pm
> 





More information about the pve-devel mailing list