[pve-devel] [PATCH qemu-server 2/2] better cleanup logging for migration

[Dominik Csapak]

On 11/27/18 12:23 PM, Thomas Lamprecht wrote:
> On 11/27/18 12:10 PM, Thomas Lamprecht wrote:
>> On 11/27/18 11:32 AM, Dominik Csapak wrote:
>>> if we migrate a vm we call cleanup but the logging looks like:
>>>
>>> Starting cleanup for 101
>>> trying to acquire lock...
>>>   OK
>>> Configuration file 'nodes/pve-ceph-01/qemu-server/101.conf' does not exist
>>>
>>> with this patch it looks like this:
>>>
>>> Starting cleanup for 101
>>> trying to acquire lock...
>>>   OK
>>> Configuration file 'nodes/pve-ceph-01/qemu-server/101.conf' does not exist
>>> Config for 101 not found, possibly migrated
>>> Finished cleanup for 101
>>
>> This isn't really better, IMO, there shouldn't be an error/warning at all
>> in this case?
> 
> you probably want to just silently exit early if the config does not exist on
> the local node?
> 

yes this is also ok, will send a v2