[pve-devel] [PATCH manager 2/2] Completing Build-Depends

[Fabian Grünbichler]

On Mon, Oct 15, 2018 at 11:59:43AM +0200, Rhonda D'Vine wrote:
>    Hi,
> 
> 
> On 10/11/2018 04:58 PM, Fabian Grünbichler wrote:
> > On Thu, Oct 11, 2018 at 12:05:20PM +0200, Rhonda D'Vine wrote:
> >> These were the missing Build-Depends that were needed in building this
> >> package.
> >>
> >> Signed-off-by: Rhonda D'Vine <rhonda at proxmox.com>
> >> ---
> > patch LGTM, the following is only semi-related ;)
> 
>  Thanks. Will send an update for the other comment.
> 
> > I assume you tested this by generating a source package and then
> > building that in a clean chroot? because when I attempt that, I get the
> > following error:
> >
> > make[2]: Entering directory '/build/pve-manager-5.2/bin'
> > cp /usr/share/pve-doc-generator/vzdump.adoc vzdump.adoc.tmp
> > mv vzdump.adoc.tmp vzdump.adoc
> > PVE_GENERATING_DOCS=1 perl -I. -e "use PVE::CLI::vzdump;print PVE::CLI::vzdump->generate_asciidoc_synopsis();" > vzdump.1-synopsis.adoc.tmp
> > /usr/share/pve-doc-generator/pve-doc-generator.mk:33: recipe for target 'vzdump.1-synopsis.adoc' failed
> > make[2]: Leaving directory '/build/pve-manager-5.2/bin'
> > Makefile:42: recipe for target 'install' failed
> 
>  That builds fine for me:
> 
> 
> make[3]: Entering directory
> '/home/rhonda/git/pve-manager/dest/bin'                                                                                                                          
> 
> cp /usr/share/pve-doc-generator/vzdump.adoc
> vzdump.adoc.tmp                                                                                  
> 
> mv vzdump.adoc.tmp
> vzdump.adoc                                                                                                               
> 
> PVE_GENERATING_DOCS=1 perl -I. -e "use PVE::CLI::vzdump;print
> PVE::CLI::vzdump->generate_asciidoc_synopsis();" >
> vzdump.1-synopsis.adoc.tmp
> mv vzdump.1-synopsis.adoc.tmp
> vzdump.1-synopsis.adoc                                                                                        
> 
> 
>  Are you sure you have all the Build-Depends installed?  How I produced
> this: I did create a stretch chroot with cowbuilder, and built in there
> (as regular user) with just installing the packages from the
> Build-Depends. I'll double check that, because actually I installed the
> pve packages that I created in that way to fulfill the Build-Depends
> instead of using the ones from the pool, so there might be something in
> there (but shouldn't, after all the packages from the pool are built
> from the same source :))

Yes, I am sure. I basically added the following on-top of your series:

---- 8< ----

diff --git a/Makefile b/Makefile
index d6837cf3..98e61781 100644
--- a/Makefile
+++ b/Makefile
@@ -27,9 +27,9 @@ $(DEB):
 	mkdir dest
 	rsync -a * dest
 	echo "git clone git://git.proxmox.com/git/pve-manager.git\\ngit checkout ${GITVERSION}" >  dest/debian/SOURCE
-	cd dest; dpkg-buildpackage -b -us -uc
+	cd dest; dpkg-buildpackage -S -us -uc -d -nc
 	# supress lintian error: statically-linked-binary usr/bin/pvemailforward
-	lintian -X binaries ${DEB}
+#	lintian -X binaries ${DEB}
 
 .PHONY: upload
 upload: ${DEB} check

---- >8 ----

and called cowbuilder build on the resulting .dsc (the chroot is
configured to use Stretch and PVE 5 repositories).

my guess is that your chroot has pve-manager installed (adding it to the
build-depends makes the problem go away, but is not the correct fix ;)).
but this whole issue in not related to your patch series, but rather a
bug in pve-doc-generator / pve-manager Makefile interaction. I'll try to
tackle it separately this week.