[pve-devel] [RFC docs/manager 0/9] new doc-generator features

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Oct 17 14:02:31 CEST 2018


On 10/17/18 1:01 PM, Fabian Grünbichler wrote:
> this series extends pve-doc-generator with the following features:
> - allow setting include directories for targets generating files via perl XXX
> - new rules for generating bash completion files
> - new rules for verifying API packages
> 
> as well as trimming down the (transitive) depends of pve-doc-generator to make
> our build-environments slimmer. I suggest running 'make update-static' and
> bumping after applying.
> 
> these new features are then used in pve-manager (which actually requires the
> first one to avoid a recursive build-depdendency on itself), along with other
> build cleanups. other repositories/packages will be cleaned up one-by-one in a
> similar fashion after this series.
> 

looks good to me after a shallow/higher level review. nice to be able to remove
the repeating %.bash-completion/verify_api rules from our packages :-)

If there are no objections on the higher level stuff I'd take a closer (in the
coming days) look and apply them, except docs 4/4 where it should be checked if
the mediawiki package really doesn't needs anything from this.

> pve-docs:
> 
> Fabian Grünbichler (4):
>   pve-doc-generator: make perl include dirs configurable
>   pve-doc-generator: add rules for bash-completion
>   pve-doc-generator: add rules for API verification
>   d/control: minimize pve-doc-generator depends
> 
>  pve-doc-generator.mk.in | 25 +++++++++++++++++++++----
>  debian/control          |  2 +-
>  2 files changed, 22 insertions(+), 5 deletions(-)
> 
> pve-manager:
> 
> Fabian Grünbichler (5):
>   build: cleanup file generation
>   build: pull REPOID into top-level Makefile
>   build: set PERL_DOC_INC_DIRS
>   build: use pve-doc-generator for bash-completion
>   build: use pve-doc-generator to verify API
> 
>  Makefile         |  9 ++++++++-
>  PVE/Makefile     |  3 +--
>  bin/Makefile     | 25 ++++++++++++-------------
>  configs/Makefile |  2 +-
>  www/Makefile     |  5 +++--
>  debian/control   |  2 +-
>  debian/rules     |  4 ++++
>  7 files changed, 30 insertions(+), 20 deletions(-)
> 






More information about the pve-devel mailing list