[pve-devel] [PATCH qemu-server 06/13] error when using vmgenid on arm

[Thomas Lamprecht]

Am 10/25/2018 um 04:19 PM schrieb Dominik Csapak:
> On 10/24/18 10:56 AM, Wolfgang Bumiller wrote:
>> Signed-off-by: Wolfgang Bumiller <w.bumiller at proxmox.com>
>> ---
>>   PVE/QemuServer.pm | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
>> index 76bd275..ab0f662 100644
>> --- a/PVE/QemuServer.pm
>> +++ b/PVE/QemuServer.pm
>> @@ -3281,6 +3281,7 @@ sub config_to_command {
>>       }
>>         if ($conf->{vmgenid}) {
>> +    die "vmgenid is not supported on arm64\n" if $arch eq 'arm64';
>>       push @$devices, '-device', 'vmgenid,guid='.$conf->{vmgenid};
>>       }
>>  
> 
> what is the error message from qemu?
> if it is meaningful i would omit an error here and let qemu handle it
> (in case arm gets vmgenid support some time in the future, we would
> still not create one by default, but not prevent users from using it)

If that happens we can still do that easily. This is a initial version
meant to improve, such details can be handled later just fine...