[pve-devel] [PATCH manager 4/4] spice: Add enhancements to VM Creation wizard

[Aaron Lauterer]

On 9/16/19 2:44 PM, Stefan Reiter wrote:
> Akin to what you mentioned on the cover, there's a connection missing 
> between the "Graphic card" field and the SPICE ones - there is no clear 
> indication of *why* they are disabled by default in a new VM.
> 
> Maybe make it a section of some sort titled "SPICE"?

Yeah, the next version of this series will contain a different layout of 
that panel that should make it clearer.

> 
> On 9/13/19 3:16 PM, Aaron Lauterer wrote:
>> enabled if qxl/spice display selected
>>
>> Signed-off-by: Aaron Lauterer <a.lauterer at proxmox.com>
>> ---
>>   www/manager6/qemu/SystemEdit.js | 18 +++++++++++++++++-
>>   1 file changed, 17 insertions(+), 1 deletion(-)
>>
>> diff --git a/www/manager6/qemu/SystemEdit.js 
>> b/www/manager6/qemu/SystemEdit.js
>> index 846baa73..15ae9a73 100644
>> --- a/www/manager6/qemu/SystemEdit.js
>> +++ b/www/manager6/qemu/SystemEdit.js
>> @@ -79,7 +79,18 @@ Ext.define('PVE.qemu.SystemInputPanel', {
>>           deleteEmpty: false,
>>           fieldLabel: gettext('Graphic card'),
>>           name: 'vga',
>> -        comboItems: PVE.Utils.kvm_vga_driver_array()
>> +        comboItems: PVE.Utils.kvm_vga_driver_array(),
>> +        listeners: {
>> +        change: function(f, value, old) {
>> +            var sef = this.up().down('pveSpiceEnhancementSelector');
>> +            if (/^(qxl)(\d?)$/.test(value)) {
>> +            console.log("matched ", value);
> 
> Leftover debug print?
> 
> Also, while this disables the enhancements in the VM creation wizard, 
> there's nothing stopping a user to just enable them afterwards in the 
> Options dialog - with no effect of course. There should be check there 
> too, I think.

See the discussion in 3/4
> 
>> +            sef.setDisabled(false);
>> +            } else {
>> +            sef.setDisabled(true);
>> +            }
>> +        }
>> +        }
>>       },
>>       {
>>           xtype: 'proxmoxcheckbox',
>> @@ -88,6 +99,11 @@ Ext.define('PVE.qemu.SystemInputPanel', {
>>           defaultValue: 0,
>>           deleteDefaultValue: true,
>>           fieldLabel: gettext('Qemu Agent')
>> +    },
>> +    {
>> +        xtype: 'pveSpiceEnhancementSelector',
>> +        name: 'spice_enhancements',
>> +        disabled: true,
>>       }
>>       ],
>>