[pve-devel] [PATCH manager 2/3] Allow setting targetstorage for offline migration

Fabian Ebner f.ebner at proxmox.com
Thu Apr 30 12:59:05 CEST 2020


Signed-off-by: Fabian Ebner <f.ebner at proxmox.com>
---
 www/manager6/window/Migrate.js | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/www/manager6/window/Migrate.js b/www/manager6/window/Migrate.js
index 9fc66a9b..20e057ad 100644
--- a/www/manager6/window/Migrate.js
+++ b/www/manager6/window/Migrate.js
@@ -44,13 +44,6 @@ Ext.define('PVE.window.Migrate', {
 		    return gettext('Offline');
 		}
 	    },
-	    setStorageselectorHidden: function(get) {
-		    if (get('migration.with-local-disks') && get('running')) {
-			return false;
-		    } else {
-			return true;
-		    }
-	    },
 	    setLocalResourceCheckboxHidden: function(get) {
 		if (get('running') || !get('migration.hasLocalResources') ||
 		    Proxmox.UserName !== 'root at pam') {
@@ -126,8 +119,7 @@ Ext.define('PVE.window.Migrate', {
 	    if (vm.get('migration.with-local-disks')) {
 		params['with-local-disks'] = 1;
 	    }
-	    //only submit targetstorage if vm is running, storage migration to different storage is only possible online
-	    if (vm.get('migration.with-local-disks') && vm.get('running')) {
+	    if (vm.get('migration.with-local-disks')) {
 		params.targetstorage = values.targetstorage;
 	    }
 
@@ -352,7 +344,7 @@ Ext.define('PVE.window.Migrate', {
 			    fieldLabel: gettext('Target storage'),
 			    storageContent: 'images',
 			    bind: {
-				hidden: '{setStorageselectorHidden}'
+				hidden: '{!migration.with-local-disks}',
 			    }
 		    },
 		    {
-- 
2.20.1





More information about the pve-devel mailing list