[pve-devel] applied: [PATCH qemu-server] Fix calls to get_replicateable_volumes

[Fabian Grünbichler]

thanks for catching this! seems like I just tested without replication, but 
not without replicatable disks..

On March 25, 2020 1:18 pm, Fabian Ebner wrote:
> There is a need to set $noerr, because otherwise migration for a
> VM with a non-replicatable volume fails with:
> missing replicate feature on volume 'myfs:107/vm-107-disk-2.raw'
> 
> Signed-off-by: Fabian Ebner <f.ebner at proxmox.com>
> ---
>  PVE/QemuMigrate.pm | 2 +-
>  PVE/QemuServer.pm  | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm
> index 4f44721..9cff64d 100644
> --- a/PVE/QemuMigrate.pm
> +++ b/PVE/QemuMigrate.pm
> @@ -330,7 +330,7 @@ sub sync_disks {
>  	    });
>  	}
>  
> -	my $replicatable_volumes = PVE::QemuConfig->get_replicatable_volumes($self->{storecfg}, $self->{vmid}, $conf);
> +	my $replicatable_volumes = PVE::QemuConfig->get_replicatable_volumes($self->{storecfg}, $self->{vmid}, $conf, 0, 1);
>  
>  	my $test_volid = sub {
>  	    my ($volid, $attr) = @_;
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index 4bc6ab4..ca18cf8 100644
> --- a/PVE/QemuServer.pm
> +++ b/PVE/QemuServer.pm
> @@ -4755,7 +4755,7 @@ sub vm_start {
>  		$local_volumes->{$ds} = [$volid, $storeid, $volname];
>  	    });
>  
> -	    my $replicatable_volumes = PVE::QemuConfig->get_replicatable_volumes($storecfg, $vmid, $conf);
> +	    my $replicatable_volumes = PVE::QemuConfig->get_replicatable_volumes($storecfg, $vmid, $conf, 0, 1);
>  
>  	    my $format = undef;
>  
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
>