[pve-devel] [PATCH] fix raise_param_exc in PVE::QemuServer::Memory::memory_unplug

Dietmar Maurer dietmar at proxmox.com
Wed Jun 8 18:55:33 CEST 2016


> >>Sigh, and we also have a cyclic include: 
> >>
> >>PVE::QemuServer => PVE::QemuServer::Memory => PVE::QemuServer 
> 
> Is it really a problem ? (you are better than me with Perl)

No, it is no 'real' problem. But it is not nice, and I think
we should try to avoid it.

> >>and ideas how to avoid that? 
> 
> Here the list of sub from QemuServer.pm used in QemuServer::Memory
> 
> PVE::QemuServer::vm_mon_cmd
> PVE::QemuServer::qemu_objectdel
> PVE::QemuServer::qemu_devicedel
> PVE::QemuServer::vm_mon_cmd_nocheck
> 
> -> could be move in a new QemuServer::Commands  for example
> 
> PVE::QemuServer::parse_hotplug_features
> 
> -> could be move in a new QemuServer::Config  for example

Yes, something like that.



More information about the pve-devel mailing list